-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimePicker format matches locale of device #3332
Conversation
Signed-off-by: rapterjet2004 <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3332-talk.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks okay and I trust the video :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested successfully
/backport to stable-17.1 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
fixes #3326
Google's default time format is 12hr, I switched it to the time format of the device itself, whether it be 12 or 24
๐ผ๏ธ Screenshots
๐๏ธ Before
issue-3326-before.webm
๐ก After
issue-3326-after.webm
๐ Checklist
/backport to stable-xx.x