Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker format matches locale of device #3332

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 21, 2023

fixes #3326

Google's default time format is 12hr, I switched it to the time format of the device itself, whether it be 12 or 24

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before

issue-3326-before.webm

๐Ÿก After

issue-3326-after.webm

๐Ÿ Checklist

  • โ›‘๏ธ Tests (unit and/or integration) are included or not needed
  • ๐Ÿ”– Capability is checked or not needed
  • ๐Ÿ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • ๐Ÿ“… Milestone is set
  • ๐ŸŒธ PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3332-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay and I trust the video :P

@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Sep 21, 2023
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully

@AndyScherzinger AndyScherzinger merged commit f4beb84 into master Sep 21, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3326-reminder-locale-bug branch September 21, 2023 20:00
@AndyScherzinger
Copy link
Member

/backport to stable-17.1

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminder feature is not using locale on the timepicker
3 participants