Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save filter state #3333

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Save filter state #3333

merged 9 commits into from
Sep 21, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 21, 2023

Remember filter states

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@@ -272,6 +276,50 @@ class ConversationsListActivity :

showSearchOrToolbar()
}
fun filterConversation() {
filterState[FilterConversationFragment.UNREAD] = appPreferences.isUnreadFilterEnabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, should be bound to the account instead of a global setting

@AndyScherzinger AndyScherzinger force-pushed the rememberFilter branch 2 times, most recently from 743a2b5 to d90fea2 Compare September 21, 2023 21:14
@AndyScherzinger AndyScherzinger self-requested a review September 21, 2023 21:24
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

tobiasKaminsky and others added 8 commits September 21, 2023 23:27
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9392
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3333-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit dec27e9 into master Sep 21, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the rememberFilter branch September 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants