fix endless loop when opening urls and files app is not installed. #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Sep 26, 2023
AndyScherzinger
force-pushed
the
bugfix/3329followup/fixToOpenLinksInBrowser
branch
from
c7810bd to
cec013f
Compare
Without this fix, the ChatActivity would be started again in FileViewerUtils. There was an endless loop between ChatActivity and FileViewerUtils because of the wrong context. Instead to open the browser, the app did nothing or freezed. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/3329followup/fixToOpenLinksInBrowser
branch
from
cec013f to
e4571be
Compare
delete-merged-branch
bot
deleted the
bugfix/3329followup/fixToOpenLinksInBrowser
branch
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3346-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #3329
Without this fix, the ChatActivity would be started again in FileViewerUtils. There was an endless loop between ChatActivity and FileViewerUtils because of the wrong context. Instead to open the browser, the app did nothing or freezed.
🏁 Checklist
/backport to stable-xx.x