Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use primary color for quoted, own messages #3354

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Use primary color for quoted, own messages #3354

merged 1 commit into from
Oct 4, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 2, 2023 •
edited
Loading

Resolves #3283

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Oct 2, 2023
@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Oct 2, 2023
@AndyScherzinger
Copy link
Member Author

/backport to stable-17.1

@AndyScherzinger AndyScherzinger marked this pull request as ready for review October 2, 2023 18:16
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 2, 2023
Closed
@AndyScherzinger
Use primary color for quoted, own messages
dab9402 
Resolves #3283

Signed-off-by: Andy Scherzinger <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3354-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@AndyScherzinger AndyScherzinger merged commit 6fa8549 into master Oct 4, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3283/quoteColor branch October 4, 2023 08:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

Own quotes are not colored correctly
1 participant
@AndyScherzinger