Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes newline characters not creating new lines #3356

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 3, 2023

Basically, replaced every "\n" with "\s\s\n" before processing. No idea why that works, but it does for some reason.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added bug Something isn't working 3. to review Waiting for reviews labels Oct 3, 2023
@rapterjet2004 rapterjet2004 self-assigned this Oct 3, 2023
@AndyScherzinger AndyScherzinger force-pushed the issue-3335-new-lines-removed branch from 1ece50d to 4e0dc89 Compare October 4, 2023 11:08
Signed-off-by: rapterjet2004 <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the issue-3335-new-lines-removed branch from 4e0dc89 to 98c6ac3 Compare October 4, 2023 11:59
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3356-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit 17851c6 into master Oct 4, 2023
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3335-new-lines-removed branch October 4, 2023 17:36
@AndyScherzinger
Copy link
Member

/backport to stable-17.1

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Oct 4, 2023

No idea why that works, but it does for some reason.

because in markdown for code-style one would add a line-break after each sentence (within a paragraph). However since it is a paragraph the line-break would not be rendered, so when you add 2 spaces (since after a sentence there would only be 1 space) this formatting rule doesn't apply anymore and the line-break gets rendered. :)

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lines removed from message
2 participants