Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting translation provider #3361

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Adjusting translation provider #3361

merged 1 commit into from
Nov 16, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 4, 2023 •
edited
Loading

Adjusting the translation feature to use the new API docs.

issue-3347-1.webm
image
  • Added 4 new model data classes
  • Added the new API function to NcApi
  • Implemented the changes in the Repository + ViewModel
  • Implemented the changes in the Activity
  • Added some helper functions to support impl

Signed-off-by: Julius Linus [email protected]

🚧 TODO

  • message actions dialog
  • API function
  • repository implementation
  • view model
  • finish activity
  • test it
  • review

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Oct 4, 2023
@rapterjet2004 rapterjet2004 force-pushed the issue-3347-adjusting-translation-provider branch 2 times, most recently from d2cb6ee to 7a60ff9 Compare October 5, 2023 13:55
@rapterjet2004 rapterjet2004 force-pushed the issue-3347-adjusting-translation-provider branch 2 times, most recently from 578ed07 to 46d0146 Compare November 15, 2023 15:15
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 15, 2023
@rapterjet2004 rapterjet2004 marked this pull request as ready for review November 15, 2023 15:47
@rapterjet2004 @mahibi
Adjusting Translation Provider
7de77ca 
- Added 4 new model data classes
- Added the new API function to NcApi
- Implemented the changes in the Repository + ViewModel
- Implemented the changes in the Activity
- Added some helper functions to support impl

Signed-off-by: Julius Linus <[email protected]>
@mahibi mahibi force-pushed the issue-3347-adjusting-translation-provider branch from 46d0146 to 7de77ca Compare November 16, 2023 15:47
@mahibi mahibi merged commit ce77633 into master Nov 16, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3347-adjusting-translation-provider branch November 16, 2023 15:47
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3361-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger added this to the 18.0.0 milestone Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews feature: 🗨️ chat feedback-requested
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

Adjust translation provider source
3 participants
@rapterjet2004 @mahibi @AndyScherzinger