Remove use of setSystemUiVisibility in previews #3372

[parneet-guraya]

Resolves: #3372

What this PR includes?

• Replace deprecated setSystemUiVisibility(int) with WindowInsetsController.
• Rendering Images in Fullscreen (including the display notch area).
• In Video view the status bar also hide/show on tapping along with other views (navigation bar, player control view) as opposed to earlier behaviour where status bar used to be hidden all the time.

🏚️ Before

Record_2023-10-10-14-54-55.mp4

🏡 After

Record_2023-10-10-14-53-21.mp4

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

works fine for me 👍
there are 2 lint errors regarding windowLayoutInDisplayCutoutMode
Could you fix this, for example by overriding FullScreenImageTheme and FullScreenMediaTheme with windowLayoutInDisplayCutoutMode in v27/styles.xml ?

[parneet-guraya]

Hi @mahibi, sure I can override the style. Actually I was aware of it just did not do it because I was not sure If I should create a separate file for just these two styles.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	89	89
Errors	0	0

SpotBugs

Category	Base	New
Correctness	9	9
Dodgy code	123	123
Internationalization	5	5
Malicious code vulnerability	3	3
Performance	8	8
Security	2	2
Total	150	150

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3373-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

thanks @parneet-guraya

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!