Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump room to 2.6.0 #3396

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Bump room to 2.6.0 #3396

merged 1 commit into from
Oct 19, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 19, 2023 •
edited
Loading

and rename paramter to match super class in case of use of names parameters

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger
Bump room to 2.6.0 and rename paramter to match super class in case o…
357b580 
…f use of names paramters

Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue dependencies labels Oct 19, 2023
@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Oct 19, 2023
@AndyScherzinger AndyScherzinger mentioned this pull request Oct 19, 2023
Closed
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice1818
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total169169

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3396-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger marked this pull request as ready for review October 19, 2023 11:08
@AndyScherzinger AndyScherzinger merged commit 4ac6624 into master Oct 19, 2023
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/Room260 branch October 19, 2023 11:09
@AndyScherzinger
Copy link
Member Author

Tested successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies technical debt Technical issue
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AndyScherzinger