Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Android Auto support #3397

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Oct 19, 2023

This PR reverts #3225

The reason for this is that somehow Google playstore doesn't accept the app anymore when Android Auto support is enabled. There were multiple emails exchanged with google, but there is no reason given that makes sense why the app is declined. Some vague hint was that is is related to Android Auto, and indeed removing Android Auto support finally solved that the app was accepted again.

One reason from Google was "We could not access the in-app content with the login credentials that you have provided". But the credentials are provided and working. So it doesn't make sense why/how this is related to Android Auto.

For now i give up to understand what's going wrong with the google playstore policy checks.

Further hints might be at https://developer.android.com/docs/quality-guidelines/car-app-quality.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice1818
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total169169

@mahibi
Copy link
Collaborator Author

mahibi commented Oct 19, 2023

The App v17.1.2 was released without Android Auto support. For now this was the only way Google accepts it.

These are the informations that google provides when declining the app with Android Auto support (No idea how "We could not access the in-app content with the login credentials that you have provided." is related to Android Auto...):


App Status: Rejected
Your app has been rejected and wasn't published due to the policy issue(s) listed below. If you submitted an update, the previous version of your app is still available on Google Play.

Issue found: Login Credentials

In order for us to review your app for compliance with Developer Program policies we will need you to provide valid login credentials for your app, and any other resources needed to review your app.

Please note the following requirements when providing login credentials:

Your login credentials must be accessible at all times, reusable, and valid regardless of user location.
Your login credentials must be maintained at all times without any error.
Your login credentials must be provided in English. Please make sure the credentials (ID, password, etc.) that you provide do not include languages other than English.
If your app requires you to bypass the login wall with other accounts (“sign in with Google, Facebook”, etc.), please provide all account details with the detailed instructions.
If your app requires the users to set up their own password (for example, PIN, etc.), please provide the instructions and upload it on Google Play Console.
Please provide all supplements (for example, QR codes, barcodes, etc.) needed in order to bypass the login wall.

In this case:

We could not access the in-app content with the login credentials that you have provided.

Additionally, follow these steps to bring your app into compliance:

Please consider following these steps to provide instructions for app access

Read the instructions in this Play Console Help Center article.
Go to the App access page.
Update your app access information.
Click Save.
Go to the Publishing overview page.
In the "Changes ready to send for review" section, click Send for review.
Read this Help Center page to learn more about managing when changes are reviewed and published.

Note: The fastest way to resolve this issue and get your app back on Google Play is follow the instructions provided above. If you have already updated valid credentials following the instructions, you do not need to contact our policy support team to provide this information. If you are unable to provide test credentials and instructions or feel our decision may have been in error, please reach out to our policy support team.
About the Auto App Quality Guidelines
We do not accept apps into Android Auto OS that don't adhere to Android for Cars Quality Guidelines.
About the Play Console Requirements
Before you submit your app for review, you must provide an active demo account, login information, and all other resources needed to review your app (i.e., login credentials, QR code, etc.)

@mahibi mahibi added this to the 17.2.0 milestone Oct 19, 2023
@mahibi mahibi added the 3. to review Waiting for reviews label Oct 19, 2023
@mahibi mahibi self-assigned this Oct 19, 2023
mahibi added a commit that referenced this pull request Oct 19, 2023
17.1.1 was skipped as it's not released on gplay, for reason see #3397

Signed-off-by: Marcel Hibbe <[email protected]>
This PR reverts #3225

The reason for this is that somehow Google playstore doesn't accept the app anymore when Android Auto support is enabled.
There were multiple emails exchanged with google, but there is no reason given that makes sense why the app is declined.
Some vague hint was that is is related to Android Auto, and indeed removing Android Auto support finally solved that the app was accepted again.

One reason from Google was "We could not access the in-app content with the login credentials that you have provided". But the credentials are provided and working. So it doesn't make sense why/how this is related to Android Auto.

For now i give up to understand what's going wrong with the google playstore policy checks.

Further hint might be at https://developer.android.com/docs/quality-guidelines/car-app-quality.

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the bugfix/noid/revertAndroidAutoSupport branch from 7f49e5d to d35c91c Compare October 24, 2023 10:13
@mahibi mahibi merged commit 25faf18 into master Oct 24, 2023
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/revertAndroidAutoSupport branch October 24, 2023 10:13
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3397-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants