Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/3408/fix login fail with umlaut in username #3409

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Bugfix/3408/fix login fail with umlaut in username #3409

merged 2 commits into from
Oct 26, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Oct 26, 2023 •
edited
Loading

fix #3408 by using UTF_8 instead ISO_8859_1

the login itself was successfull, but the error happened when fetching the capabilities.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 2 commits October 26, 2023 13:25
@mahibi
Use UTF_8 for basic authorization
e578801 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
reformat code
0e3c24b 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added the 3. to review Waiting for reviews label Oct 26, 2023
@mahibi mahibi added this to the 17.1.3 milestone Oct 26, 2023
@mahibi mahibi self-assigned this Oct 26, 2023
@mahibi mahibi requested a review from nickvergessen October 26, 2023 11:34
nickvergessen
nickvergessen approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess

@mahibi mahibi modified the milestones: 17.1.3, 18.0.0 Oct 26, 2023
@mahibi
Copy link
Collaborator Author

mahibi commented Oct 26, 2023

/backport to stable-17.1

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice1818
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total169169

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3409-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 0de2600 into master Oct 26, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3408/fixLoginFailWithUmlautInUsername branch October 26, 2023 13:16
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

Login fails when using Umlauts in username (AD)
2 participants
@mahibi @nickvergessen