Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve chat list disappears on configuration change #3430

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

parneet-guraya
Copy link
Contributor

@parneet-guraya parneet-guraya commented Nov 5, 2023

fix #3407

Before

Record_2023-10-26-04-15-19.mp4

After

Record_2023-11-06-01-47-40.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@parneet-guraya parneet-guraya requested a review from mahibi November 5, 2023 20:33
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Nov 5, 2023
@AndyScherzinger AndyScherzinger force-pushed the issue/chat-clear-config-change branch from 992f245 to 3bbec0f Compare November 8, 2023 09:27
@AndyScherzinger AndyScherzinger added this to the 18.0.0 milestone Nov 8, 2023
@AndyScherzinger
Copy link
Member

/backport to stable-17.1

@mahibi
Copy link
Collaborator

mahibi commented Nov 8, 2023

nice catch @parneet-guraya 👍

your commit seems to be not signed, could you check this? https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@parneet-guraya
Copy link
Contributor Author

Hi @mahibi 👋, yes it is not verified, I think it's because @AndyScherzinger did a force update. I'm pushing again from my side.

Signed-off-by: parneet-guraya <[email protected]>
@parneet-guraya parneet-guraya force-pushed the issue/chat-clear-config-change branch from 3bbec0f to f23075b Compare November 8, 2023 13:47
@mahibi mahibi enabled auto-merge November 8, 2023 13:48
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

Copy link
Contributor

github-actions bot commented Nov 8, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3430-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit b631b85 into master Nov 8, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue/chat-clear-config-change branch November 8, 2023 14:30
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat disappears on configuration change for the first time.
3 participants