Fix to delete user when unregister for notifications failed #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
commented
Nov 20, 2023
| @@ -129,6 +129,7 @@ public void onNext(@io.reactivex.annotations.NonNull GenericOverall genericOvera | |||
| @Override | |||
| public void onError(@io.reactivex.annotations.NonNull Throwable e) { | |||
| Log.e(TAG, "error while trying to unregister Device For Notifications", e); | |||
| initiateUserDeletion(user); | |||
There was a problem hiding this comment.
especially this missing deletion command caused bugs..
Nextcloud Server? Invalid auth because the token was removed, ... |
Whenever there was an error when unregistering from notifications, the user was not deleted. This could lead to multiple bugs. Furthermore, external signaling server connection and arbitrary storage is now always handled for user deletion, which was not the case before. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/noid/deleteUserWhenUnregisterForNotificationsFailed
branch
from
021af62 to
423ce97
Compare
delete-merged-branch
bot
deleted the
bugfix/noid/deleteUserWhenUnregisterForNotificationsFailed
branch
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3454-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not yet tested, but from my pov this should...
fix #3243
fix #3105
Not sure for which cases unregister for notifications might fail, maybe @nickvergessen knows best.
Further improvements for user deletions will come with #3436
🚧 TODO
🏁 Checklist
/backport to stable-xx.x