Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/noid/fix save file dialog #3466

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 27, 2023

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot_20231127_142107 geaendert Screenshot_20231127_141507 geaendert

🚧 TODO

  • material3??

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

(seemed to be caused by c&p)

Signed-off-by: Marcel Hibbe <[email protected]>
fix text color for dark mode in save file dialog from FullScreen*Activity

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 27, 2023

/backport to stable-18.0

@mahibi mahibi added this to the 18.1.0 milestone Nov 27, 2023
@mahibi mahibi self-assigned this Nov 27, 2023
@mahibi mahibi added the 3. to review Waiting for reviews label Nov 27, 2023
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3466-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think it's about m3, I think we usually dynamically theme all colorings including the text, I think.

@AndyScherzinger AndyScherzinger self-requested a review November 27, 2023 17:53
@AndyScherzinger AndyScherzinger merged commit da5d47b into master Nov 28, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/fixSaveFileDialog branch November 28, 2023 09:38
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 28, 2023

Don't think it's about m3, I think we usually dynamically theme all colorings including the text, I think.

yeah m3 is unrelated here, just thought about it as the textsizes of the dialog are different when open it via context menu with longclick on the file, or when you open it via FullScreen*Activity.

image

image

I temporarily applied m3 design to FullScreen*Activity which worked, but iirc then the colors of the appbar menu are wrong in dark mode..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants