-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/noid/fix save file dialog #3466
Conversation
(seemed to be caused by c&p) Signed-off-by: Marcel Hibbe <[email protected]>
fix text color for dark mode in save file dialog from FullScreen*Activity Signed-off-by: Marcel Hibbe <[email protected]>
/backport to stable-18.0 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3466-talk.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think it's about m3, I think we usually dynamically theme all colorings including the text, I think.
yeah m3 is unrelated here, just thought about it as the textsizes of the dialog are different when open it via context menu with longclick on the file, or when you open it via FullScreen*Activity. I temporarily applied m3 design to FullScreen*Activity which worked, but iirc then the colors of the appbar menu are wrong in dark mode.. |
πΌοΈ Screenshots
π§ TODO
π Checklist
/backport to stable-xx.x