Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate "no proxy" in settings #3474

Merged
merged 1 commit into from
Nov 29, 2023
Merged

translate "no proxy" in settings #3474

merged 1 commit into from
Nov 29, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 29, 2023 •
edited
Loading

fix #3472

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Nov 29, 2023
@mahibi mahibi added this to the 18.1.0 milestone Nov 29, 2023
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 29, 2023

/backport to stable-18.0

@mahibi mahibi requested a review from rapterjet2004 November 29, 2023 10:10
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

@mahibi mahibi force-pushed the bugfix/3472/translateNoProxy branch from 3481b77 to f6b481c Compare November 29, 2023 10:43
@mahibi mahibi merged commit 83a3d39 into master Nov 29, 2023
13 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3472/translateNoProxy branch November 29, 2023 10:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3474-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
None yet
Projects
None yet
Milestone
18.1.0
Development

Successfully merging this pull request may close these issues.

Add to translation
2 participants
@mahibi @AndyScherzinger