Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-18.0] Bug Fix - IllegalStateException in stopAudioRecording + Polishes #3475

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #3453

- Implement MediaRecorderState handling
- Fixed lifecycle bug - recording and locked UI now ends after app exits
- Saves Waveform to storage after initial loading
- Fixes File caption crashes
- A couple other bugs

Signed-off-by: Julius Linus <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3475-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit c933ad5 into stable-18.0 Nov 29, 2023
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3453/stable-18.0 branch November 29, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: 🗨️ chat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants