Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving Webinar Settings #3484

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Saving Webinar Settings #3484

merged 1 commit into from
Dec 1, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Nov 30, 2023 •
edited
Loading

There was a typo in the url webinary instead of webinar 🫠

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Nov 30, 2023
@rapterjet2004 rapterjet2004 self-assigned this Nov 30, 2023
@rapterjet2004 rapterjet2004 added the bug Something isn't working label Nov 30, 2023
@rapterjet2004 rapterjet2004 force-pushed the issue-3473-saving-webinar-settings branch from 64f170b to 53793a2 Compare November 30, 2023 14:40
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

@mahibi mahibi force-pushed the issue-3473-saving-webinar-settings branch from 53793a2 to 1efa14e Compare December 1, 2023 12:32
@mahibi mahibi merged commit a8cacf1 into master Dec 1, 2023
13 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3473-saving-webinar-settings branch December 1, 2023 12:33
@mahibi
Copy link
Collaborator

mahibi commented Dec 1, 2023 •
edited
Loading

nice find. added onError handling

@mahibi mahibi added this to the 18.1.0 milestone Dec 1, 2023
@mahibi
Copy link
Collaborator

mahibi commented Dec 1, 2023

/backport to stable-18.0

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 1, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3484-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Milestone
18.1.0
Development

Successfully merging this pull request may close these issues.

No saving of Webinar settings Lobby management is not working
2 participants
@rapterjet2004 @mahibi