Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid error when declining recording consent #3502

Merged
merged 1 commit into from
Dec 5, 2023
Merged

avoid error when declining recording consent #3502

merged 1 commit into from
Dec 5, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Dec 5, 2023 •
edited
Loading

fix #3491

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
avoid error when declining recording consent
6ac9fa5 
When declining recording consent, 404 might be returned when leaving the call (because the call was not joined before).
It might not be the best option to handle this via onError, but for the moment (18.0.0 release) it's the most robust/lowest-risk solution without to change some state handling to check if the call was joined).
finish was added which makes sense anyway, but for declining recording consent the error snackbar was removed.

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added the 3. to review Waiting for reviews label Dec 5, 2023
@mahibi mahibi added this to the 18.1.0 milestone Dec 5, 2023
@mahibi mahibi self-assigned this Dec 5, 2023
@mahibi
Copy link
Collaborator Author

mahibi commented Dec 5, 2023

/backport to stable-18.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Codacy

Lint

TypemasterPR
Warnings8484
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3502-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi enabled auto-merge December 5, 2023 15:39
@mahibi mahibi merged commit 8507e96 into master Dec 5, 2023
18 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3491/fixErrorWhenDecliningRecConsent branch December 5, 2023 17:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
18.1.0
Development

Successfully merging this pull request may close these issues.

error when declining recording consent
2 participants
@mahibi @AndyScherzinger