DatabaseStorageModule not working correctly

[rapterjet2004]

Room was overwriting old data in ArbitraryStorage, because there was a conflict detected in ArbitraryStoragesDao
@Insert(onConflict = OnConflictStrategy.REPLACE). This was because the composite primary key wasn't including the conversation token as well. primaryKeys = ["accountIdentifier", "key"]

ToDo

• Create a Migration from Dual Key to Triple Key
• Test Migrations

Before

issue-3506-before.mp4

After

issue-3506-after.mp4

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

@rapterjet2004 without having taken a deeper look into it, it seems you didn't implement a DB migration to "9" which is needed I think either an auto migration or an actual one.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	83	83
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3506-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

i suggest to not merge this PR in favor of #3569
extending the primary key might make it more difficult to implement data migrations etc.

Anyway good catch Julius 👍 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!