Bump hwsecurity-fido from 2.4.5 to 4.1.0-patch2

[AndyScherzinger]

Preparation for sdk=34, as needed by the files app where this fix got implemented first

🚧 TODO

• check if this still works

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[AndyScherzinger]

@tobiasKaminsky @mahibi is any of you able to test this? Asking since I do not have such a key that can be used with a phone

[tobiasKaminsky]

I can test this, yes.

[tobiasKaminsky]

On Firefox on Android I can use my NFC Fido Key.
Within Talk it says "your browser does not support WebAuthn".

So either this is broken or something else…

2023-12-18 09:11:36.964  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(6)] "fidobridge start execution", source:  (6)
2023-12-18 09:11:36.964  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(75)] "fidobridge end execution", source:  (75)
2023-12-18 09:11:37.855  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "JQMIGRATE: Migrate is installed, version 3.4.1", source: https://nextcloud.kaminsky.me/dist/core-common.js?v=d715ff10-58 (2)
2023-12-18 09:11:37.923  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "session heartbeat polling started", source: https://nextcloud.kaminsky.me/dist/core-main.js?v=d715ff10-58 (2)
2023-12-18 09:11:54.845  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(0)] "Error with Feature-Policy header: Unrecognized feature: 'payment'.", source:  (0)
2023-12-18 09:11:54.883  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(6)] "fidobridge start execution", source:  (6)
2023-12-18 09:11:54.883  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(75)] "fidobridge end execution", source:  (75)
2023-12-18 09:11:55.831  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "JQMIGRATE: Migrate is installed, version 3.4.1", source: https://nextcloud.kaminsky.me/dist/core-common.js?v=d715ff10-58 (2)
2023-12-18 09:11:56.230  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "[DEBUG] twofactor_webauthn: start sign [object Object]", source: https://nextcloud.kaminsky.me/apps/twofactor_webauthn/js/challenge.js?v=d715ff10-58 (2)
2023-12-18 09:11:56.231  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "[DEBUG] twofactor_webauthn: Starting webauthn authentication [object Object]", source: https://nextcloud.kaminsky.me/apps/twofactor_webauthn/js/challenge.js?v=d715ff10-58 (2)
2023-12-18 09:11:56.234  7298-7298  chromium                com.nextcloud.talk2                  I  [INFO:CONSOLE(2)] "session heartbeat polling started", source: https://nextcloud.kaminsky.me/dist/core-main.js?v=d715ff10-58 (2)

With latest dev version of Files it still works.

[AndyScherzinger]

Hmmm, webAuthn needs the fido2 dependency but I don't know if it auto-registers or if there is something on top that needs to be done.
We would need to check how Files implemented webAuthn support using the lib or if it has just been about adding the dependency and be done with it.

[tobiasKaminsky]

I am currently adding webauthn, similar to what Files did.
Seems that I never tested it after our 2fa was migrated to webauthn serverside.

[tobiasKaminsky]

Tested and works 👍

[AndyScherzinger]

Tested and works 👍

Nice work @tobiasKaminsky and thanks for this xmas present 🎁

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	83	83
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3510-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.