Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioUtils bug fix for media playback #3515

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Dec 13, 2023

Guarantees, that regardless of Codec State, the process will end at 3 seconds, sharp. Returning an Empty float array if not finished. This should make it compatible with slower devices. Also guarantees that the MediaExtractor is not null before queuing a new input buffer, which might stop some bugs that prevent the MediaCodec.BUFFER_FLAG_END_OF_STREAM flag from being set.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added bug Something isn't working 3. to review Waiting for reviews labels Dec 13, 2023
@rapterjet2004 rapterjet2004 requested a review from mahibi December 13, 2023 19:12
@rapterjet2004 rapterjet2004 self-assigned this Dec 13, 2023
@mahibi mahibi added this to the 18.1.0 milestone Dec 15, 2023
@mahibi
Copy link
Collaborator

mahibi commented Dec 15, 2023

/backport to stable-18.0

@mahibi mahibi force-pushed the issue-3325-audioutils-bug-fix branch from 8840ec7 to 49d6578 Compare December 22, 2023 15:05
@mahibi mahibi merged commit 866a3a9 into master Dec 22, 2023
13 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-3325-audioutils-bug-fix branch December 22, 2023 15:06
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8383
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3515-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to execute audio messages with Talk Android 17.1.0
2 participants