Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated GIFS in Chat #4030

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Animated GIFS in Chat #4030

wants to merge 3 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jul 26, 2024

Paused to focus on offline support

🖼️ Screenshots

issue-3975-gifphy-2.webm

🚧 TODO

  • Fix Downloading to Cache
  • Make Gifs bigger
  • Fix weird bug with images. Gifs are saved to cache, but the placeholder image is an unrelated photo.
    • Debug the previewMessageViewHolder. isGif is working, it's a problem with the image loader.
    • Debug the image loader. Image loader works fine, its the link that's an Image. But getting the gif link leads to an SSL exception -_-.
    • Debug the GifImageView. Perhaps it's saving previous image state, which could be messing things up.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: rapterjet2004 <[email protected]>
@migulen
Copy link

migulen commented Jul 26, 2024

Great!!!

… images to the chat - something wrong with the placeholder logic - I should check the adapter

Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9090
Errors129129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4030-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animate GIFs
2 participants