Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User avatar selection #4196

Merged
merged 6 commits into from
Sep 12, 2024
Merged

User avatar selection #4196

merged 6 commits into from
Sep 12, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Sep 12, 2024 •
edited
Loading

Resolve #4176

  • Choose a conversation avatar from device's camera, gallery, or Nextcloud files and set the avatar.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the user_avatar_selection branch 3 times, most recently from 7f1fab0 to 272d28e Compare September 12, 2024 12:56
@sowjanyakch sowjanyakch self-assigned this Sep 12, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Sep 12, 2024
@mahibi mahibi force-pushed the user_avatar_selection branch from 272d28e to 6bc3b1a Compare September 12, 2024 15:30
@mahibi mahibi merged commit 946aa60 into master Sep 12, 2024
13 of 17 checks passed
@mahibi mahibi deleted the user_avatar_selection branch September 12, 2024 15:30
@mahibi
Copy link
Collaborator

mahibi commented Sep 12, 2024

/backport to stable-20.0

@mahibi mahibi added this to the 20.1.0 milestone Sep 12, 2024
@backportbot backportbot bot mentioned this pull request Sep 12, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8693
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4196-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

avatar editing for new conversation screen
2 participants
@sowjanyakch @mahibi