Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing temporary messages when queued #4251

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Showing temporary messages when queued #4251

merged 14 commits into from
Oct 22, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 19, 2024

🖼️ Screenshots

Screenshot 2024-10-01 at 10 13 10 AM

🚧 TODO

  • Got UI working
  • Maintain state on lifecycle changes
  • Allow editing
  • Allow deleting
    • Note: Works but weird delay bug on deleting last one
    • fix bug where deleting message then adding another increments counter by +2 instead of +1
  • handle replies
  • fix bugs where messages timeout - might be a room error
  • fix bugs with duplicate queued messages on room enter

Follow up

  • handle failed to send?
  • Send all queued messages when connection is regained
  • Get the Image link from the cache

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Sep 19, 2024
@rapterjet2004 rapterjet2004 marked this pull request as ready for review October 1, 2024 13:25
@mahibi

This comment was marked as resolved.

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see video

@mahibi

This comment was marked as resolved.

@mahibi

This comment was marked as resolved.

@rapterjet2004 rapterjet2004 requested a review from mahibi October 8, 2024 12:46
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
@mahibi mahibi force-pushed the show-temp-messages branch from 20ce2e8 to b192e0e Compare October 22, 2024 09:12
@mahibi
Copy link
Collaborator

mahibi commented Oct 22, 2024

approved. One bug that should be fixed in a followup:

  • Go offline
  • send messages to queue
  • go back to converstion list
  • go back to chat
    --> message queue is not shown. Only the hint that messages are queued.

@mahibi mahibi enabled auto-merge October 22, 2024 09:30
@mahibi mahibi merged commit b39db64 into master Oct 22, 2024
15 of 16 checks passed
@mahibi mahibi deleted the show-temp-messages branch October 22, 2024 09:38
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9497
Errors132132

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4251-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator

mahibi commented Nov 8, 2024

/backport to stable-20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants