Fix Codacy Warnings - Ensure Composable Function Names Start with a Capital Letter #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowjanyakch
force-pushed
the
solve_static_code_warnings
branch
from
07037a1 to
66153b6
Compare
sowjanyakch
changed the title
sowjanyakch
force-pushed
the
solve_static_code_warnings
branch
from
66153b6 to
03e477b
Compare
mahibi
reviewed
Sep 23, 2024
detekt.yml
Outdated
| @@ -278,7 +278,7 @@ naming: | |||
| minimumFunctionNameLength: 3 | |||
| FunctionNaming: | |||
| active: true | |||
| functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$' | |||
| functionPattern: '^([a-z$A-Z][a-zA-Z$0-9]*)|(.*)$' | |||
There was a problem hiding this comment.
I see for the last part at the files app, it is still using the ` quotes around (.*)
Whats the difference?
There was a problem hiding this comment.
By using quotes around (.*), we can use function names enclosed in backticks. This is a common notation in unit test cases. I will include the backticks.
Signed-off-by: sowjanyakch <[email protected]>
sowjanyakch
force-pushed
the
solve_static_code_warnings
branch
from
03e477b to
78a55c0
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4256-talk.apk |
mahibi
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4014
solve codacy lint warning for composables.
The static code analysis gives a warning when composable functions name start with a capital letter. The functionPattern should be modified to write a composable function name with a capital letter.
🚧 TODO
🏁 Checklist
/backport to stable-xx.x