Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle link clicks properly #4297

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −2
Draft

handle link clicks properly #4297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...rc/main/java/com/nextcloud/talk/adapters/messages/IncomingLinkPreviewMessageViewHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ package com.nextcloud.talk.adapters.messages

import android.annotation.SuppressLint
import android.content.Context
import android.content.Intent
import android.net.Uri
import android.text.SpannableString
import android.text.Spanned
import android.text.TextUtils
import android.text.style.UnderlineSpan
import android.util.Log
import android.view.View
import androidx.core.content.ContextCompat
Expand Down Expand Up @@ -92,6 +97,16 @@ class IncomingLinkPreviewMessageViewHolder(incomingView: View, payload: Any) :

binding.messageText.text = processedMessageText

val link = SpannableString(processedMessageText)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processedMessageText can be mixed text with hyperlinks. So "test http://anysite.com" can't be directly converted to a link but the link has to be extracted and only this should be underlined and clickable.
Otherwise there could be a ActivityNotFoundException if the link is not valid.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to extract links, code from

talk-android/app/src/main/java/com/nextcloud/talk/chat/data/model/ChatMessage.kt

Line 167 in 7ca68b3

fun isLinkPreview(): Boolean {

will be helpful. This is the code which decides if the *LinkPreviewMessageViewHolder is applied.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However thinking about that there can be multiple links inside a message this gets more complicated. Then there might have to be more complex logic similar like it's used for the chip mentions:

talk-android/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt

Line 220 in 9d62a6f

fun searchAndReplaceWithMentionSpan(

link.setSpan(UnderlineSpan(), 0, link.length, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE)
binding.messageText.text = link

binding.messageText.setOnClickListener {
val browserIntent = Intent(Intent.ACTION_VIEW, Uri.parse(processedMessageText.toString()))
browserIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
context.startActivity(browserIntent)
}

setAvatarAndAuthorOnMessageItem(message)

colorizeMessageBubble(message)
Expand Down
15 changes: 14 additions & 1 deletion ...c/main/java/com/nextcloud/talk/adapters/messages/OutcomingLinkPreviewMessageViewHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ package com.nextcloud.talk.adapters.messages

import android.annotation.SuppressLint
import android.content.Context
import android.content.Intent
import android.net.Uri
import android.text.SpannableString
import android.text.Spanned
import android.text.style.UnderlineSpan
import android.util.Log
import android.view.View
import androidx.appcompat.content.res.AppCompatResources
Expand Down Expand Up @@ -84,7 +89,15 @@ class OutcomingLinkPreviewMessageViewHolder(outcomingView: View, payload: Any) :
itemView
)

binding.messageText.text = processedMessageText
val link = SpannableString(processedMessageText)
link.setSpan(UnderlineSpan(), 0, link.length, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE)
binding.messageText.text = link

binding.messageText.setOnClickListener {
val browserIntent = Intent(Intent.ACTION_VIEW, Uri.parse(processedMessageText.toString()))
browserIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
context.startActivity(browserIntent)
}

itemView.isSelected = false

Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/layout/activity_chat.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@
app:outcomingTextLinkColor="@color/high_emphasis_text"
app:outcomingTextSize="@dimen/chat_text_size"
app:outcomingTimeTextSize="12sp"
app:textAutoLink="all"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing
app:textAutoLink="all"
works and may be mandatory to fix the bug.

However this will change the behavior of all ChatMessage types and automatic link detection won't work as described in
#3481 (comment)

tools:visibility="visible" />

<com.nextcloud.ui.popupbubble.PopupBubble
Expand Down
Loading