Fix DB migration 11 to 12 #4417
Conversation
There was a problem hiding this comment.
Sorry about that, should have checked the json 😅
also the tests seem to be failing because of the error I sent you
Resource compilation failed (Failed to compile values resource file /drone/src/app/build/intermediates/incremental/genericDebug/mergeGenericDebugResources/merged.dir/values-ug/values-ug.xml
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/noid/fixDbMigration11to12
branch
from
a677cc5 to
4ff9b2b
Compare
no need to be sorry. |
|
ok something is still wrong when trying out the migration, will have a closer look |
this will set NOT NULL and DEFAULT 0 to hasArchived column Otherwise there would be an error when updating from the previous DB version: IllegalStateException: Migration didn't properly handle: Conversations(com.nextcloud.talk.data.database.model.ConversationEntity) Signed-off-by: Marcel Hibbe <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4417-talk.apk |
|
no backport by intention as #4333 is not backported.. |
https://github.com/nextcloud/talk-android/pull/4333/files was merged with modified 11.json instead to create 12.json.
This PR will revert 11.json to the old state and and 12.json (DB migration is already in place, just the json was missing)
Not sure if it could have been a problem for released alpha versions, but luckily(😄) the alpha build that could have been affected failed because of a translation error.
🏁 Checklist
/backport to stable-xx.x