Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock room #4428

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Lock room #4428

merged 4 commits into from
Nov 14, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 8, 2024

Resolve #3664

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review November 8, 2024 19:34
@sowjanyakch sowjanyakch self-assigned this Nov 8, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4428-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Codacy

Lint

TypemasterPR
Warnings94152
Errors13287

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message input field must be disabled when a conversation is locked.

update: IIRC it's locked when leaving and opening the chat again. Improvements to this may be related to #4354 so solving it is out of scope for this PR.

@sowjanyakch sowjanyakch requested a review from mahibi November 14, 2024 15:30
@sowjanyakch sowjanyakch merged commit 5ff1003 into master Nov 14, 2024
17 of 20 checks passed
@sowjanyakch sowjanyakch deleted the lock_room branch November 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to lock and unlock the room from the information menu
3 participants