fix to provide all call emojis #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with my Samsung A52 and it shows all emoji's and they are packed. Please see the screenshot.
|
As the number of provided emojis grew, there was a bug that only one emoji was shown. Putting all 12 emojis would have been too close, so it's implemented to scroll them horizontally Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
bugfix/noid/fixCallEmojiListByScrolling
branch
from
c050719 to
cd5ee2f
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4436-talk.apk |
sowjanyakch
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the number of provided emojis grew (from 10 to 12), there was a bug that only one emoji was shown.
Putting all 12 emojis in one fixed row would have been too close, so it's implemented to scroll them horizontally
🏚️ Before
🏡 After
emojis.in.call.mp4
🏁 Checklist
/backport to stable-xx.x