Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from Rxjava to coroutines #4 #4461

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Migrating from Rxjava to coroutines #4 #4461

merged 12 commits into from
Nov 21, 2024

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4413

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Coroutine 4 Migrating from Rxjava to coroutines #4 Nov 18, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review November 18, 2024 17:36
@sowjanyakch sowjanyakch self-assigned this Nov 18, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94153
Errors13281

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7471
Internationalization33
Malicious code vulnerability33
Performance54
Security11
Total108104

Lint increased!

@sowjanyakch @mahibi
convert rxjava to coroutine - favourite conversation
68366b3 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoint
e9d2a86 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert rxjava to coroutine - unfavourite conversation
9ba07f5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoints
75d1c54 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
Rename .java to .kt
9e8a547 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert java code to kotlin - DatabaseStorageModule
77b55dc 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert rxjava to coroutines - notification calls
f4f943f 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoints
1d9f475 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert rxjava to coroutines - set expiration and set notification le…
5094cf5 
…vels for messages

Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoints
af7a395 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
use constants
33314cf 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
lint warnings
626994e 
Signed-off-by: sowjanyakch <[email protected]>
@mahibi mahibi enabled auto-merge November 21, 2024 09:52
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4461-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 8fa3c7b into master Nov 21, 2024
13 of 16 checks passed
@mahibi mahibi deleted the coroutine_4 branch November 21, 2024 09:59
@mahibi mahibi added this to the 20.1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Migrate some RxJava to coroutines #4
2 participants
@sowjanyakch @mahibi