Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coroutine_5 #4464

Merged
merged 8 commits into from
Nov 21, 2024
Merged

coroutine_5 #4464

merged 8 commits into from
Nov 21, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 18, 2024 •
edited
Loading

Resolve #4414

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Nov 18, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 18, 2024
sowjanyakch and others added 8 commits November 21, 2024 11:05
@sowjanyakch @mahibi
convert rxjava to coroutines - ban actor
7ae39bf 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoint
3bc3a8e 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert rxjava to coroutines - list bans
121d7e6 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused code
bdda04c 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
convert rxjava to coroutines - unban actor
a95433c 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
remove unused endpoint
fa3e800 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch @mahibi
write logs for exceptions in viewModel
ebfb38b 
Signed-off-by: sowjanyakch <[email protected]>
@mahibi
add setConversationReadOnly
e8cf3ee 
must have been lost during resolving merge conflicts

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added this to the 20.1.0 milestone Nov 21, 2024
@mahibi mahibi enabled auto-merge November 21, 2024 10:19
@mahibi mahibi merged commit c9d84c2 into master Nov 21, 2024
12 of 16 checks passed
@mahibi mahibi deleted the coroutine_5 branch November 21, 2024 10:26
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94154
Errors13276

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7471
Internationalization33
Malicious code vulnerability33
Performance54
Security11
Total108104

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4464-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Migrate some RxJava to coroutines #5
2 participants
@sowjanyakch @mahibi