Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a search bar to the "Join Open Conversations" screen #4471

Merged
merged 3 commits into from
Nov 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/inspectionProfiles/ktlint.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ import android.content.Intent
import android.graphics.drawable.ColorDrawable
import android.os.Bundle
import android.view.View
import androidx.core.widget.doOnTextChanged
import androidx.lifecycle.ViewModelProvider
import autodagger.AutoInjector
import com.google.android.material.snackbar.Snackbar
import com.nextcloud.android.common.ui.theme.utils.ColorRole
import com.nextcloud.talk.R
import com.nextcloud.talk.activities.BaseActivity
import com.nextcloud.talk.api.NcApi
Expand All @@ -23,6 +25,7 @@ import com.nextcloud.talk.openconversations.adapters.OpenConversationsAdapter
import com.nextcloud.talk.openconversations.data.OpenConversation
import com.nextcloud.talk.openconversations.viewmodels.OpenConversationsViewModel
import com.nextcloud.talk.utils.bundle.BundleKeys
import com.vanniktech.ui.showKeyboardAndFocus
import javax.inject.Inject

@AutoInjector(NextcloudTalkApplication::class)
Expand All @@ -40,6 +43,8 @@ class ListOpenConversationsActivity : BaseActivity() {

lateinit var adapter: OpenConversationsAdapter

var searching = false

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
NextcloudTalkApplication.sharedApplication!!.componentApplication.inject(this)
Expand All @@ -52,15 +57,35 @@ class ListOpenConversationsActivity : BaseActivity() {
setupActionBar()
setContentView(binding.root)
setupSystemColors()
viewThemeUtils.platform.colorImageView(binding.searchOpenConversations, ColorRole.ON_SURFACE)
viewThemeUtils.platform.colorEditText(binding.searchEdit)

val user = currentUserProvider.currentUser.blockingGet()

adapter = OpenConversationsAdapter(user) { conversation -> adapterOnClick(conversation) }
binding.openConversationsRecyclerView.adapter = adapter
binding.searchOpenConversations.setOnClickListener {
searching = !searching
handleSearchUI(searching)
}
binding.searchEdit.doOnTextChanged { text, _, _, count ->
adapter.filter(text.toString())
}

initObservers()
}

private fun handleSearchUI(show: Boolean) {
if (show) {
binding.searchOpenConversations.visibility = View.GONE
binding.searchEdit.visibility = View.VISIBLE
binding.searchEdit.showKeyboardAndFocus()
} else {
binding.searchOpenConversations.visibility = View.VISIBLE
binding.searchEdit.visibility = View.GONE
}
}

private fun adapterOnClick(conversation: OpenConversation) {
val bundle = Bundle()
bundle.putString(BundleKeys.KEY_ROOM_TOKEN, conversation.roomToken)
Expand Down Expand Up @@ -105,7 +130,12 @@ class ListOpenConversationsActivity : BaseActivity() {
private fun setupActionBar() {
setSupportActionBar(binding.openConversationsToolbar)
binding.openConversationsToolbar.setNavigationOnClickListener {
onBackPressedDispatcher.onBackPressed()
if (searching) {
handleSearchUI(false)
searching = false
} else {
onBackPressedDispatcher.onBackPressed()
}
}
supportActionBar?.setDisplayHomeAsUpEnabled(true)
supportActionBar?.setDisplayShowHomeEnabled(true)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import com.nextcloud.talk.openconversations.data.OpenConversation

class OpenConversationsAdapter(val user: User, private val onClick: (OpenConversation) -> Unit) :
ListAdapter<OpenConversation, OpenConversationsAdapter.OpenConversationsViewHolder>(ConversationsCallback) {
private var originalList: List<OpenConversation> = emptyList()
private var isFiltering = false

inner class OpenConversationsViewHolder(val itemBinding: RvItemOpenConversationBinding) :
RecyclerView.ViewHolder(itemBinding.root) {
Expand Down Expand Up @@ -68,6 +70,36 @@ class OpenConversationsAdapter(val user: User, private val onClick: (OpenConvers
val conversation = getItem(position)
holder.bindItem(conversation)
}

fun filter(text: String) {
if (text == "") {
submitList(originalList)
isFiltering = false
return
}

isFiltering = true
val newList = mutableListOf<OpenConversation>()
for (conversation in originalList) {
if (conversation.displayName.contains(text, true) || conversation.description!!.contains(text, true)) {
newList.add(conversation)
}
}

if (newList.isNotEmpty()) {
submitList(newList)
}
}

override fun onCurrentListChanged(
previousList: MutableList<OpenConversation>,
currentList: MutableList<OpenConversation>
) {
if (!isFiltering) {
originalList = currentList
}
super.onCurrentListChanged(previousList, currentList)
}
}

object ConversationsCallback : DiffUtil.ItemCallback<OpenConversation>() {
Expand Down
20 changes: 19 additions & 1 deletion app/src/main/res/layout/activity_open_conversations.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
android:id="@+id/open_conversations_appbar"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/open_conversations_toolbar"
android:layout_width="match_parent"
Expand All @@ -26,7 +27,24 @@
app:layout_scrollFlags="scroll|enterAlways"
app:navigationIconTint="@color/fontAppbar"
app:popupTheme="@style/appActionBarPopupMenu"
app:titleTextColor="@color/fontAppbar" />
app:titleTextColor="@color/fontAppbar" >

<ImageView
android:id="@+id/search_open_conversations"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:contentDescription="@string/search_icon"
android:layout_gravity="end"
android:layout_marginHorizontal="@dimen/standard_margin"
android:src="@drawable/ic_search_white_24dp" />

<com.google.android.material.textfield.TextInputEditText
android:id="@+id/search_edit"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:visibility="gone"
/>
</com.google.android.material.appbar.MaterialToolbar>
</com.google.android.material.appbar.AppBarLayout>

<androidx.recyclerview.widget.RecyclerView
Expand Down
Loading