Feature/4363/display email guests #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
feature/4363/displayEmailGuests
branch
from
a194d3f to
592672e
Compare
|
If a user doesn't set a display name, no avatar or username will be shown on Android. On the web, a default avatar will be displayed, and the user will be named 'Guest'.
|
|
Whenever a display name of the guest is edited, guest name in the chat is not updated. |
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
objectId would be some long random string for email guests. displaying them would not make sense. It's also not done on web. Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
knowing if a guest did not change it's name is not possible at this point, so we also show the letter "G" if it's name is guest Signed-off-by: Marcel Hibbe <[email protected]>
… any name However this is only possible for the conversation info. In other parts, the info if a guest changed the name or not is not available (like in the chat or in autocomplete) Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
also: create ChatMessageUtils as helper for the ViewHolders in this case. Could help to avoid duplicated code until there is a clear inheritance solution. Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
feature/4363/displayEmailGuests
branch
from
592672e to
8e08d92
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4473-talk.apk |
i can't reproduce the mentioned behaviors. I merged to have it in RC1, but we will have a closer look and fix these things in a followup PR if necessary |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #4363
how to test:
and check the views below...
chat view
conversation info view
call view
🏁 Checklist
/backport to stable-xx.x