Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display conversation avatar for open conversations #4493

Merged
merged 8 commits into from
Dec 10, 2024
Merged

display conversation avatar for open conversations #4493

merged 8 commits into from
Dec 10, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 27, 2024 •
edited by mahibi
Loading

Resolve #4489

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Avatar open conversation display conversation avatar for open conversations Nov 27, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review November 27, 2024 17:54
@sowjanyakch sowjanyakch self-assigned this Nov 27, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 27, 2024
@mahibi mahibi force-pushed the avatar_open_conversation branch from 1795c33 to d48ec4b Compare December 3, 2024 12:10
@mahibi mahibi enabled auto-merge December 3, 2024 12:25
@mahibi mahibi added this to the 21.0.0 milestone Dec 3, 2024
@mahibi
Copy link
Collaborator

mahibi commented Dec 3, 2024

/backport to stable-20.1

mahibi
mahibi requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove OpenConversation and OpenConversationModel? If i saw correctly they are not used anymore

@sowjanyakch sowjanyakch requested a review from mahibi December 3, 2024 14:39
@sowjanyakch sowjanyakch force-pushed the avatar_open_conversation branch from 81e39aa to 1282233 Compare December 3, 2024 15:06
sowjanyakch and others added 8 commits December 10, 2024 09:22
@mahibi mahibi force-pushed the avatar_open_conversation branch from 1282233 to c32d6a5 Compare December 10, 2024 08:24
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4493-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7372

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@mahibi mahibi merged commit a268819 into master Dec 10, 2024
18 checks passed
@mahibi mahibi deleted the avatar_open_conversation branch December 10, 2024 08:42
@backportbot backportbot bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

Avatars for "Join open conversations"
2 participants
@sowjanyakch @mahibi