Add clear icon for search view in open conversations

[sowjanyakch]

Resolve #4490

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

Could you have a closer look how much work it is to use a SearchView (https://developer.android.com/reference/com/google/android/material/search/SearchView) here? I think it would make more sense as it's intended to use with the appbar.

If SearchView is not possible for whatever reason, then you should wrap the
TextInputEditText inside a TextInputLayout which will also give you the possibility to use built in cancel button etc.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4497-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	158	158
Errors	72	72

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	16	16
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	104	104

[mahibi]

when typing, the result list should also be updated if there searched string doesn't match anymore.

For example there are 3 rooms called "Talk".
When i search for "Tal", all 3 rooms are shown.
But when i add a letter that doesn't match, the results should disappear. So when i type "Talx", the old results are still shown.

[sowjanyakch]

I will implement the search bug in a different PR.