Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update avatar icons #4505

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update avatar icons #4505

merged 2 commits into from
Dec 2, 2024

Conversation

AndyScherzinger
Copy link
Member

Resolvses #4466

Closes #4480

...by simply replacing all icon work, no code changes needed. This way it is ensured the graphical assets get replaced in a visually consistent way

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Dec 2, 2024
@AndyScherzinger AndyScherzinger force-pushed the style/4466/updateAvatarIcons branch from 8e54985 to 7eaf098 Compare December 2, 2024 15:15
@AndyScherzinger AndyScherzinger changed the title Style/4466/update avatar icons Update avatar icons Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4505-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7373

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@mahibi mahibi merged commit 2340272 into master Dec 2, 2024
18 checks passed
@mahibi mahibi deleted the style/4466/updateAvatarIcons branch December 2, 2024 16:17
@AndyScherzinger
Copy link
Member Author

/backport to stable-20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants