Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detekt score #4519

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Improve detekt score #4519

merged 4 commits into from
Dec 6, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Dec 4, 2024

Drive down detekt score from more than 200 to 122 by fixing or ignoring some of the high volume items.

One commit per detekt rule

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue labels Dec 4, 2024
@AndyScherzinger AndyScherzinger added this to the 21.0.0 milestone Dec 4, 2024
@AndyScherzinger AndyScherzinger force-pushed the style/noid/improveDetektScore branch from f79feca to abebe6f Compare December 6, 2024 10:12
Copy link
Contributor

github-actions bot commented Dec 6, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4519-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7373

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@mahibi mahibi merged commit 4c52871 into master Dec 6, 2024
18 checks passed
@mahibi mahibi deleted the style/noid/improveDetektScore branch December 6, 2024 11:04
@nextcloud nextcloud deleted a comment from backportbot bot Dec 6, 2024
@mahibi
Copy link
Collaborator

mahibi commented Dec 6, 2024

/backport to stable-20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants