-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve detekt score #4519
Merged
Merged
Improve detekt score #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
added
3. to review
Waiting for reviews
technical debt
Technical issue
labels
Dec 4, 2024
Signed-off-by: Andy Scherzinger <[email protected]>
…tation Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger
force-pushed
the
style/noid/improveDetektScore
branch
from
December 6, 2024 10:12
f79feca
to
abebe6f
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4519-talk.apk |
mahibi
approved these changes
Dec 6, 2024
/backport to stable-20.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive down detekt score from more than 200 to 122 by fixing or ignoring some of the high volume items.
One commit per detekt rule
🏁 Checklist
/backport to stable-xx.x