Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hilt dependency #4522

Merged
merged 1 commit into from
Dec 10, 2024
Merged

remove hilt dependency #4522

merged 1 commit into from
Dec 10, 2024

Conversation

sowjanyakch
Copy link
Contributor

This PR removes unused hilt dependency.

Renovate failed to update the Hilt dependency due to a conflict between Hilt and KSP plugins #4019 . The Hilt plugin is applied in the root project, while KSP is applied in a sub-project, which causes compatibility issues. To avoid complexity, the unused hilt plugin has been removed.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Dec 5, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Dec 5, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review December 5, 2024 16:35
Signed-off-by: sowjanyakch <[email protected]>
@mahibi mahibi force-pushed the remove_hilt_dependency branch from acaca4a to 46e8201 Compare December 10, 2024 08:36
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7273

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4522-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit cbce4e9 into master Dec 10, 2024
17 checks passed
@mahibi mahibi deleted the remove_hilt_dependency branch December 10, 2024 09:05
@mahibi mahibi added this to the 21.0.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants