Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update notification checklist #4542

Merged
merged 1 commit into from
Dec 13, 2024
Merged

update notification checklist #4542

merged 1 commit into from
Dec 13, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Dec 12, 2024

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Dec 12, 2024
@mahibi mahibi self-assigned this Dec 12, 2024
@mahibi mahibi force-pushed the doc/updateNotificationChecklist branch from 5e27a3e to a29e210 Compare December 12, 2024 16:43
@mahibi
update notification checklist
9da7602 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the doc/updateNotificationChecklist branch from a29e210 to 9da7602 Compare December 13, 2024 10:01
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7272

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4542-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 10203b5 into master Dec 13, 2024
16 checks passed
@sowjanyakch sowjanyakch deleted the doc/updateNotificationChecklist branch December 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @sowjanyakch