Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set remainder for messages in federated conversation #4546

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Set remainder for messages in federated conversation #4546

merged 1 commit into from
Dec 13, 2024

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4535

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review December 13, 2024 09:09
@sowjanyakch sowjanyakch self-assigned this Dec 13, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Dec 13, 2024
@sowjanyakch sowjanyakch force-pushed the set_remainder_in-federated_conversation branch from 3b99dae to 41f74e4 Compare December 13, 2024 10:18
@mahibi mahibi force-pushed the set_remainder_in-federated_conversation branch from 41f74e4 to 49c717c Compare December 13, 2024 12:44
@mahibi mahibi enabled auto-merge December 13, 2024 12:44
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings158158
Errors7272

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4546-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 19c5b14 into master Dec 13, 2024
17 checks passed
@mahibi mahibi deleted the set_remainder_in-federated_conversation branch December 13, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not set reminder in federated conversation
2 participants
@sowjanyakch @mahibi