Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit bot messages in 1:1 conversations #4747

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

edit bot messages in 1:1 conversations #4747

wants to merge 12 commits into from
+180 −50

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Feb 21, 2025 •
edited
Loading

Resolve #4708

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Fix edit bot messages edit bot messages in 1:1 conversations Feb 21, 2025
@sowjanyakch sowjanyakch force-pushed the fix_edit_bot_messages branch from c46a4d6 to 0502d7f Compare February 21, 2025 13:27
@sowjanyakch
edit bot messages
6d85641 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
time limit to edit bot messages is 24 hours
07bea20 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
align layout properly
1d5e16f 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use interactive checkbox
7df1ef7 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
edit message on clicking checkboxes
86c1789 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
refactor code
aa6c7d8 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
handle multiple checkboxes
9c0c6f1 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
apply theming
174eea5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
adjust layout
c108842 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use constants
bfed721 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the fix_edit_bot_messages branch from 0502d7f to fb37209 Compare February 21, 2025 14:07
@sowjanyakch
fix detekt
c9239a1 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the fix_edit_bot_messages branch from fb37209 to c9239a1 Compare February 21, 2025 14:13
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4747-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow editing of bot messages in one-to-one
1 participant
@sowjanyakch