Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): use notification state API to check whether to dismiss notification #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 5, 2024

☑️ Resolves

Should be compatible with original method to handle 4 cases:

Case new API state original method intended action
Call pending, not joined status 200 false loop again
Call ended, not joined status 201 null -> resolve(false) dismiss and show 'missed call'
Call pending, already joined status 404 true - resolve(true) dismiss and show nothing
Other error ? catch error loop again

🚧 Tasks

  • Test

@Antreesy Antreesy added 2. developing technical debt Maintenance and refactoring labels Dec 5, 2024
@Antreesy Antreesy added this to the 🌠 Next Patch milestone Dec 5, 2024
@Antreesy Antreesy requested a review from DorraJaouad December 5, 2024 14:33
@Antreesy Antreesy self-assigned this Dec 5, 2024
@Antreesy Antreesy force-pushed the fix/961/handle-missed-calls branch from 683788b to cd85084 Compare December 6, 2024 12:48
Base automatically changed from fix/961/handle-missed-calls to main December 6, 2024 14:00
@Antreesy Antreesy force-pushed the feat/13930/talk-notification-state branch from d7d57f8 to 3f69fb1 Compare December 11, 2024 16:35
@Antreesy Antreesy marked this pull request as ready for review December 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant