Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): do not create native notification for old entries #967

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(notifications): do not create native notification for old entries #967

merged 1 commit into from
Dec 10, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 6, 2024

☑️ Resolves

To test:

  • create any Talk notification
  • execute occ notification:test-push userid 25 times to fill the server response
  • start Desktop client
  • dismiss one of dummy notifications
  • wait for the next 200 response

🖼️ Screenshots

🏚️ Before 🏡 After
Old notification No notification

🚧 Tasks

  • Test

@Antreesy Antreesy added bug Something isn't working 3. to review labels Dec 6, 2024
@Antreesy Antreesy added this to the 🌠 Next Patch milestone Dec 6, 2024
@Antreesy Antreesy self-assigned this Dec 6, 2024
nickvergessen
nickvergessen approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good otherwise

@Antreesy Antreesy force-pushed the fix/961/notification-threshold branch from 2def7b1 to bb01c82 Compare December 9, 2024 11:44
DorraJaouad
DorraJaouad approved these changes Dec 9, 2024
View reviewed changes
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise ✅

@Antreesy Antreesy merged commit 9d308d1 into main Dec 10, 2024
10 checks passed
@Antreesy Antreesy deleted the fix/961/notification-threshold branch December 10, 2024 08:31
@Antreesy Antreesy mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
🌠 Next Patch
Development

Successfully merging this pull request may close these issues.

Incoming call is shown for old notifications
3 participants
@Antreesy @nickvergessen @DorraJaouad