Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed "Cancel" to "Close" in some dialogs #1879

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Changed "Cancel" to "Close" in some dialogs #1879

merged 3 commits into from
Nov 20, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 self-assigned this Nov 15, 2024
@rapterjet2004 rapterjet2004 force-pushed the issue-1781-fix-dialog-naming branch from d18f4ba to 3cc2d81 Compare November 15, 2024 14:30
Ivansss
Ivansss requested changes Nov 18, 2024
View reviewed changes
NextcloudTalk/QRCodeLoginController.swift Outdated Show resolved Hide resolved
NextcloudTalk/PollCreationViewController.swift Outdated Show resolved Hide resolved
NextcloudTalk/SettingsTableViewController.swift Outdated Show resolved Hide resolved
NextcloudTalk/ShareLocationViewController.m Outdated Show resolved Hide resolved
NextcloudTalk/VoiceMessageTranscribeViewController.m Outdated Show resolved Hide resolved
@rapterjet2004 @SystemKeeper
Changed Cancel to Close in Dialog
385016e 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 @SystemKeeper
Replaced 'Close' with 'OK'
8ec1ae8 
- Settings button seems to already be implemented

Signed-off-by: rapterjet2004 <[email protected]>
@SystemKeeper SystemKeeper force-pushed the issue-1781-fix-dialog-naming branch from c0e7bbf to 8ec1ae8 Compare November 18, 2024 20:11
@SystemKeeper
Copy link
Collaborator

Rebased because of deprecated CI action used. Should run now.

@rapterjet2004
Replaced all 'Ok' with 'OK'
0ea584a 
Signed-off-by: rapterjet2004 <[email protected]>
Ivansss
Ivansss approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @rapterjet2004 :)

@Ivansss Ivansss merged commit 30f598a into master Nov 20, 2024
11 checks passed
@Ivansss Ivansss deleted the issue-1781-fix-dialog-naming branch November 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@rapterjet2004 rapterjet2004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some dialogs use Cancel instead of Close
3 participants
@rapterjet2004 @SystemKeeper @Ivansss