Skip to content

Commit

Permalink
fix(ci): err due to update-node-dist being canceled
Browse files Browse the repository at this point in the history
The `update-node-dist` workflow pushes a new commit to the branch it runs on.
This commit triggers the workflow again.
Prevent the second workflow from canceling the first
just before the first would have finished.

Every time the workflow is canceled it sends out a notification.

Without `cancel-in-progress` there will be at most one workflow running and one pending.

Most of the time the pending workflow will be the one that resulted from the commit pushed by the running workflow.

If two PRs are merged quickly after each other
first run will be finished even though it was not needed.
However this will happen rarely and will at most waste a few minutes of CI runtime.

Signed-off-by: Max <[email protected]>
  • Loading branch information
max-nextcloud committed Dec 19, 2024
1 parent 702ef89 commit 92da92f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/update-node-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:

concurrency:
group: update-node-dist-${{ github.head_ref || github.ref || github.run_id }}
cancel-in-progress: true

jobs:
update-node-dist:
Expand Down

0 comments on commit 92da92f

Please sign in to comment.