feat(session): Send save request via sendBeacon at beforeunload
#6798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas <[email protected]>
This will send a final save request on unsaved changes via the browsers native `navigator.sendBeacon()` function when navigating away from the website or the tab/browser is closed. Fixes: #6606 Signed-off-by: Jonas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6798 +/- ##
==========================================
- Coverage 46.76% 46.74% -0.03%
==========================================
Files 748 740 -8
Lines 34162 34177 +15
Branches 1242 1234 -8
==========================================
Hits 15976 15976
- Misses 17564 17587 +23
+ Partials 622 614 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This will send a final save request on unsaved changes via the browsers native
navigator.sendBeacon()function when navigating away from the website or the tab/browser is closed.Fixes: #6606
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)