Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notifier::prepare() threw \InvalidArgumentException which is dep… #6806

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

nickvergessen
Copy link
Member

…recated

📝 Summary

If a user has any notifications this log is generated all the time:

OCA\Text\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr
Copy link
Member

Thanks a lot ❤️

@juliusknorr juliusknorr force-pushed the bugfix/noid/notification-handling branch from ce98b48 to 21f0dae Compare January 3, 2025 11:28
@juliusknorr juliusknorr merged commit 3e78434 into main Jan 3, 2025
65 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/notification-handling branch January 3, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants