Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): bump vue from 2.7.16 to v3 #677

Closed
wants to merge 1 commit into from
Closed

fix(deps): bump vue from 2.7.16 to v3 #677

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 25, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vue (source) ^2.7.16 -> ^3.0.0-alpha age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2024-9506

The ReDoS can be exploited through the parseHTML function in the html-parser.ts file. This flaw allows attackers to slow down the application by providing specially crafted input that causes inefficient processing of regular expressions, leading to excessive resource consumption.

To demonstrate this vulnerability, here's an example. In a Vue client-side application, create a new Vue instance with a template string that includes a <script> tag but closes it incorrectly with something like </textarea>.

new Vue({
  el: '#app',
  template: '
    <div>
      Hello, world!
      <script>${'<'.repeat(1000000)}</textarea>
    </div>'
});

Next, set up a basic HTML page (e.g., index.html) to load this JavaScript and mount the Vue instance:

<!DOCTYPE html>
<html>
<head>
  <title>My first Vue app</title>
</head>
<body>
  <div id=\"app\">Loading...</div>
</body>
</html>

When you visit the app in your browser at http://localhost:3000, you'll notice that the time taken to parse and mount the Vue application increases significantly due to the ReDoS vulnerability, demonstrating how the flaw can affect performance.

ReDoS vulnerability in vue package that is exploitable through inefficient regex evaluation in the parseHTML function

CVE-2024-9506 / GHSA-5j4c-8p2g-v4jx

More information

Details

The ReDoS can be exploited through the parseHTML function in the html-parser.ts file. This flaw allows attackers to slow down the application by providing specially crafted input that causes inefficient processing of regular expressions, leading to excessive resource consumption.

To demonstrate this vulnerability, here's an example. In a Vue client-side application, create a new Vue instance with a template string that includes a <script> tag but closes it incorrectly with something like </textarea>.

new Vue({
  el: '#app',
  template: '
    <div>
      Hello, world!
      <script>${'<'.repeat(1000000)}</textarea>
    </div>'
});

Next, set up a basic HTML page (e.g., index.html) to load this JavaScript and mount the Vue instance:

<!DOCTYPE html>
<html>
<head>
  <title>My first Vue app</title>
</head>
<body>
  <div id=\"app\">Loading...</div>
</body>
</html>

When you visit the app in your browser at http://localhost:3000, you'll notice that the time taken to parse and mount the Vue application increases significantly due to the ReDoS vulnerability, demonstrating how the flaw can affect performance.

Severity

  • CVSS Score: 3.7 / 10 (Low)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:L

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).

Configuration

📅 Schedule: Branch creation - "before 7am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
fix(deps): bump vue from 2.7.16 to v3
b3a7451 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Oct 25, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 25, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @linusborg/[email protected]
npm warn Found: [email protected]
npm warn node_modules/vue
npm warn   vue@"^3.0.0-alpha" from the root project
npm warn   4 more (vue-demi, vue-demi, vue-demi, emoji-mart-vue-fast)
npm warn
npm warn Could not resolve dependency:
npm warn peer vue@"^2.6.6" from @linusborg/[email protected]
npm warn node_modules/@linusborg/vue-simple-portal
npm warn   @linusborg/vue-simple-portal@"^0.1.5" from @nextcloud/[email protected]
npm warn   node_modules/@nextcloud/vue
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/vue
npm warn   peer vue@"^2.6.6" from @linusborg/[email protected]
npm warn   node_modules/@linusborg/vue-simple-portal
npm warn     @linusborg/vue-simple-portal@"^0.1.5" from @nextcloud/[email protected]
npm warn     node_modules/@nextcloud/vue
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @nextcloud/[email protected]
npm error Found: [email protected]
npm error node_modules/vue
npm error   vue@"^3.0.0-alpha" from the root project
npm error   peer vue@"^3.0.0-0 || ^2.6.0" from [email protected]
npm error   node_modules/@vueuse/components/node_modules/vue-demi
npm error     vue-demi@">=0.14.10" from @vueuse/[email protected]
npm error     node_modules/@vueuse/components
npm error       @vueuse/components@"^11.0.0" from @nextcloud/[email protected]
npm error       node_modules/@nextcloud/vue
npm error         @nextcloud/vue@"^8.19.0" from the root project
npm error         1 more (@nextcloud/password-confirmation)
npm error   3 more (vue-demi, vue-demi, emoji-mart-vue-fast)
npm error
npm error Could not resolve dependency:
npm error peer vue@"^2.7.16" from @nextcloud/[email protected]
npm error node_modules/@nextcloud/password-confirmation
npm error   @nextcloud/password-confirmation@"^5.1.1" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/vue
npm error   peer vue@"^2.7.16" from @nextcloud/[email protected]
npm error   node_modules/@nextcloud/password-confirmation
npm error     @nextcloud/password-confirmation@"^5.1.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-10-25T00_56_26_483Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-10-25T00_56_26_483Z-debug-0.log

@renovate renovate bot requested review from ChristophWurst and st3iny October 25, 2024 00:56
@st3iny st3iny closed this Oct 25, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 25, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/npm-vue-vulnerability branch October 25, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@st3iny st3iny Awaiting requested review from st3iny

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@st3iny