Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more edge case detection + more informative error reporting [Web mode] #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

Attempt to be more informative when unexpected things happen + catch more edge cases.

Currently we return Parsing response failed when something goes wrong at any given step (since everything falls back on the JSON check). The underlying problem isn't always JSON related though. It's just our default response.

Let's be more informative and catch a few more potential edge cases while we're at it.

We should be as defensive as possible everywhere, but certainly in the Updater.

  • Add handling for additional potential edge cases (i.e. loss of network connectivity or DNS)
  • Add some more information to help distinguish between different error states
  • Add more robust check for valid JSON
  • Don't generate the summary HTML element (and useless Show detailed response button) if the details are going to be empty
  • Refactor: use a common error response function (to eliminate duplicate code across the steps)
  • Refactor: Misc minor (i.e. formatting)

@joshtrichards joshtrichards added enhancement 2. developing robustness 💪 Enhancements (and bugs) related to robustness labels Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement robustness 💪 Enhancements (and bugs) related to robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant