fix: more edge case detection + more informative error reporting [Web mode] #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to be more informative when unexpected things happen + catch more edge cases.
Currently we return
Parsing response failed
when something goes wrong at any given step (since everything falls back on the JSON check). The underlying problem isn't always JSON related though. It's just our default response.Let's be more informative and catch a few more potential edge cases while we're at it.
We should be as defensive as possible everywhere, but certainly in the Updater.
summary
HTML element (and useless Show detailed response button) if thedetails
are going to be empty