Fix reloading NC after logging out from IDP #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobia De Koninck <[email protected]>
AndyScherzinger
force-pushed
the
fix_reload_idp_logout
branch
from
0c843c8
to
35f7483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #345
Using: Nextcloud master (17) user_saml master and keycloak
4.8.3.Final.Steps to reproduce:
https://idp/auth/realms/my-realm/account/Expected
After the #334 and #340 it is expected to be logged out and redirected to the login page of the SSO again.
Actual Result
You get a redirect loop:
The third request doesn't have a valid CRSF token and fails.