feat(keepEmptyGroups): Add app configuration parameter to keep empty groups

[marcojarjour]

• Add config flag to keep empty groups

Ref: #833

[blizzz]

Hey @marcojarjour,

thank you for this contribution!

Generally this is an improvement we surely can have.

I'd like to ask you to switch the config away from config.php and turn it into an app-config via $this->config->getAppValue().

One word on whether to have this setting IdP-dependent or as a general flag, like you implemented it. The first one allows more fine-grained control, but I am doubtful this is necessary. So going with the global approach is fine.

You may consider adding a global configuration knob for this as well, but it would regard it optional for acceptance. It's ok to have it as a hidden flag in the beginning.

In the ideal case, equip this with an integration test. While preferred, I would take it also without one since the change is simple and not dangerous. It's just that code may change over time and having one makes it more robust.

[blizzz]

P.S.: and please sign your commit to let the DCO test pass, cf. https://github.com/nextcloud/user_saml/pull/911/checks?check_run_id=33591334717

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[marcojarjour]

@blizzz sorry for pinging you again, but maybe you missed my comment on the Issue. It would be great if you could review the pull request.

[blizzz]

@marcojarjour indeed missed it, thank you for notifying me again!

[blizzz]

One suggested change to apply, otherwise good to go!

[blizzz]

Um, could you remove the merge branch? If updating, then use "Update with rebase", please, but usually it is not necessary, unless there are conflicts (or known dependencies with recently merged pull requests)

[marcojarjour]

Um, could you remove the merge branch? If updating, then use "Update with rebase", please, but usually it is not necessary, unless there are conflicts (or known dependencies with recently merged pull requests)

🤦 oh sorry, i am not really used to GitHub and erroneously did the merge update. Its removed. Sorry for the extra work and thanks for your patience.

[blizzz]

Um, could you remove the merge branch? If updating, then use "Update with rebase", please, but usually it is not necessary, unless there are conflicts (or known dependencies with recently merged pull requests)

🤦 oh sorry, i am not really used to GitHub and erroneously did the merge update. Its removed. Sorry for the extra work and thanks for your patience.

No worries ☺️ and thanks for the effort brought in here 🙇